Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer.conf: update LAYERSERIES_COMPAT for styhead #1314

Closed
wants to merge 1 commit into from
Closed

layer.conf: update LAYERSERIES_COMPAT for styhead #1314

wants to merge 1 commit into from

Conversation

sangmo-kang
Copy link
Contributor

oe-core switched to styhead in: https://git.openembedded.org/openembedded-core/commit?id=cef91ebeb3f2b1d41336fff60555064430a80397

  • What I did
    Add styhead to LAYERSERIES_COMPAT and remove nanbiled.

  • How I did it
    Update LAYERSERIES_COMPAT_raspberrypi in conf/layer.conf

@kraj
Copy link
Collaborator

kraj commented May 8, 2024

Hmm I think we need to branch scarthgap to apply this to master otherwise we will have to remove this from scarthgap branch whenever we create it

@shr-project
Copy link
Contributor

oe-core didn't switch to styhead yet, this is premature as it was in meta-qt5/meta-qt5#563

It doesn't need to be updated yet, both scarthgap and styhead are still in oe-core:

LAYERSERIES_CORENAMES = "scarthgap styhead"

We shouldn't declare compatibility with styhead until we're close to styhead release (and scarthgap is dropped from oe-core's LAYERSERIES_CORENAMES) because we don't know what changes styhead compatibility will need and if this layer will be updated to meet them.

This can be applied after 4-5 months.

@sangmo-kang
Copy link
Contributor Author

Dear @shr-project, @kraj
Thank you for the commet. Then, I close this PR.

@kraj
Copy link
Collaborator

kraj commented May 29, 2024

oe-core didn't switch to styhead yet, this is premature as it was in meta-qt5/meta-qt5#563

It doesn't need to be updated yet, both scarthgap and styhead are still in oe-core:

LAYERSERIES_CORENAMES = "scarthgap styhead"

We shouldn't declare compatibility with styhead until we're close to styhead release (and scarthgap is dropped from oe-core's LAYERSERIES_CORENAMES) because we don't know what changes styhead compatibility will need and if this layer will be updated to meet them.

This can be applied after 4-5 months.

I think the UNPACKDIR changes are forcing master to diverge faster than we would have imagined. So Think we should merge this change into master sooner rather than later

@kraj kraj reopened this May 29, 2024
@kraj
Copy link
Collaborator

kraj commented May 29, 2024

@agherzan FYI

@shr-project
Copy link
Contributor

@agherzan FYI

@kraj it's included in #1329

@kraj
Copy link
Collaborator

kraj commented May 29, 2024

@agherzan FYI

@kraj it's included in #1329

ah superb, closing this one in favor of #1329

@kraj kraj closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants