-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Raspberry Pi Camera Module v3 to Kirkstone (compatibility patch) #1197
Open
Jessseee
wants to merge
2
commits into
agherzan:kirkstone
Choose a base branch
from
Jessseee:kirkstone
base: kirkstone
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
196 changes: 196 additions & 0 deletions
196
recipes-kernel/linux/files/0003-recipe-bsp-Add-imx708-dt-overlay-files.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,196 @@ | ||
| From a66bb44e8c32170d2de5ea29ae16b30d9a5e2b06 Mon Sep 17 00:00:00 2001 | ||
| From: Jesse Visser <[email protected]> | ||
| Date: Thu, 9 Mar 2023 11:19:34 +0100 | ||
| Subject: [PATCH] recipe-bsp: Add imx708 dt-overlay files | ||
|
|
||
| Signed-off-by: Jesse Visser <[email protected]> | ||
| --- | ||
| recipes-kernel/linux/files/imx708-overlay.dts | 105 ++++++++++++++++++ | ||
| recipes-kernel/linux/files/imx708.dtsi | 35 ++++++ | ||
| recipes-kernel/linux/linux-raspberrypi-dev.bb | 2 + | ||
| .../linux/linux-raspberrypi_5.10.bb | 2 + | ||
| 4 files changed, 144 insertions(+) | ||
| create mode 100644 recipes-kernel/linux/files/imx708-overlay.dts | ||
| create mode 100644 recipes-kernel/linux/files/imx708.dtsi | ||
|
|
||
| diff --git a/recipes-kernel/linux/files/imx708-overlay.dts b/recipes-kernel/linux/files/imx708-overlay.dts | ||
| new file mode 100644 | ||
| index 0000000..6efbe09 | ||
| --- /dev/null | ||
| +++ b/recipes-kernel/linux/files/imx708-overlay.dts | ||
| @@ -0,0 +1,105 @@ | ||
| +// SPDX-License-Identifier: GPL-2.0-only | ||
| +// Definitions for IMX708 camera module on VC I2C bus | ||
| +/dts-v1/; | ||
| +/plugin/; | ||
| + | ||
| +#include <dt-bindings/gpio/gpio.h> | ||
| + | ||
| +/{ | ||
| + compatible = "brcm,bcm2835"; | ||
| + | ||
| + fragment@0 { | ||
| + target = <&i2c0if>; | ||
| + __overlay__ { | ||
| + status = "okay"; | ||
| + }; | ||
| + }; | ||
| + | ||
| + clk_frag: fragment@1 { | ||
| + target = <&cam1_clk>; | ||
| + __overlay__ { | ||
| + status = "okay"; | ||
| + clock-frequency = <24000000>; | ||
| + }; | ||
| + }; | ||
| + | ||
| + fragment@2 { | ||
| + target = <&i2c0mux>; | ||
| + __overlay__ { | ||
| + status = "okay"; | ||
| + }; | ||
| + }; | ||
| + | ||
| + reg_frag: fragment@3 { | ||
| + target = <&cam1_reg>; | ||
| + cam_reg: __overlay__ { | ||
| + startup-delay-us = <70000>; | ||
| + off-on-delay-us = <30000>; | ||
| + regulator-min-microvolt = <2700000>; | ||
| + regulator-max-microvolt = <2700000>; | ||
| + }; | ||
| + }; | ||
| + | ||
| + fragment@4 { | ||
| + target = <&cam_node>; | ||
| + __overlay__ { | ||
| + lens-focus = <&vcm_node>; | ||
| + }; | ||
| + }; | ||
| + | ||
| + i2c_frag: fragment@100 { | ||
| + target = <&i2c_csi_dsi>; | ||
| + __overlay__ { | ||
| + #address-cells = <1>; | ||
| + #size-cells = <0>; | ||
| + status = "okay"; | ||
| + | ||
| + #include "imx708.dtsi" | ||
| + }; | ||
| + }; | ||
| + | ||
| + csi_frag: fragment@101 { | ||
| + target = <&csi1>; | ||
| + csi: __overlay__ { | ||
| + status = "okay"; | ||
| + brcm,media-controller; | ||
| + | ||
| + port { | ||
| + csi_ep: endpoint { | ||
| + remote-endpoint = <&cam_endpoint>; | ||
| + clock-lanes = <0>; | ||
| + data-lanes = <1 2>; | ||
| + clock-noncontinuous; | ||
| + }; | ||
| + }; | ||
| + }; | ||
| + }; | ||
| + | ||
| + __overrides__ { | ||
| + rotation = <&cam_node>,"rotation:0"; | ||
| + orientation = <&cam_node>,"orientation:0"; | ||
| + media-controller = <&csi>,"brcm,media-controller?"; | ||
| + cam0 = <&i2c_frag>, "target:0=",<&i2c_vc>, | ||
| + <&csi_frag>, "target:0=",<&csi0>, | ||
| + <&clk_frag>, "target:0=",<&cam0_clk>, | ||
| + <®_frag>, "target:0=",<&cam0_reg>, | ||
| + <&cam_node>, "clocks:0=",<&cam0_clk>, | ||
| + <&cam_node>, "VANA1-supply:0=",<&cam0_reg>, | ||
| + <&vcm_node>, "VDD-supply:0=",<&cam0_reg>; | ||
| + vcm = <&vcm_node>, "status", | ||
| + <0>, "=4"; | ||
| + link-frequency = <&cam_endpoint>,"link-frequencies#0"; | ||
| + }; | ||
| +}; | ||
| + | ||
| +&cam_node { | ||
| + status = "okay"; | ||
| +}; | ||
| + | ||
| +&cam_endpoint { | ||
| + remote-endpoint = <&csi_ep>; | ||
| +}; | ||
| + | ||
| +&vcm_node { | ||
| + status = "okay"; | ||
| +}; | ||
| diff --git a/recipes-kernel/linux/files/imx708.dtsi b/recipes-kernel/linux/files/imx708.dtsi | ||
| new file mode 100644 | ||
| index 0000000..1558458 | ||
| --- /dev/null | ||
| +++ b/recipes-kernel/linux/files/imx708.dtsi | ||
| @@ -0,0 +1,35 @@ | ||
| +// Fragment that configures a Sony IMX708 | ||
| + | ||
| +cam_node: imx708@1a { | ||
| + compatible = "sony,imx708"; | ||
| + reg = <0x1a>; | ||
| + status = "disabled"; | ||
| + | ||
| + clocks = <&cam1_clk>; | ||
| + clock-names = "inclk"; | ||
| + | ||
| + vana1-supply = <&cam1_reg>; /* 2.8v */ | ||
| + vana2-supply = <&cam_dummy_reg>;/* 1.8v */ | ||
| + vdig-supply = <&cam_dummy_reg>; /* 1.1v */ | ||
| + vddl-supply = <&cam_dummy_reg>; /* 1.8v */ | ||
| + | ||
| + rotation = <180>; | ||
| + orientation = <2>; | ||
| + | ||
| + port { | ||
| + cam_endpoint: endpoint { | ||
| + clock-lanes = <0>; | ||
| + data-lanes = <1 2>; | ||
| + clock-noncontinuous; | ||
| + link-frequencies = | ||
| + /bits/ 64 <450000000>; | ||
| + }; | ||
| + }; | ||
| +}; | ||
| + | ||
| +vcm_node: dw9817@c { | ||
| + compatible = "dongwoon,dw9817-vcm"; | ||
| + reg = <0x0c>; | ||
| + status = "disabled"; | ||
| + VDD-supply = <&cam1_reg>; | ||
| +}; | ||
| diff --git a/recipes-kernel/linux/linux-raspberrypi-dev.bb b/recipes-kernel/linux/linux-raspberrypi-dev.bb | ||
Jessseee marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| index e0a4461..7d263c3 100644 | ||
| --- a/recipes-kernel/linux/linux-raspberrypi-dev.bb | ||
| +++ b/recipes-kernel/linux/linux-raspberrypi-dev.bb | ||
| @@ -24,6 +24,8 @@ SRC_URI = " \ | ||
| git://git.yoctoproject.org/yocto-kernel-cache;type=kmeta;name=meta;branch=${LINUX_RPI_KMETA_BRANCH};destsuffix=${KMETA} \ | ||
| file://powersave.cfg \ | ||
| file://android-drivers.cfg \ | ||
| + file://imx708-overlay.dts;subdir=git/arch/${ARCH}/boot/dts/overlays \ | ||
| + file://imx708-overlay.dtsi;subdir=git/arch/${ARCH}/boot/dts/overlays \ | ||
| " | ||
|
|
||
| require linux-raspberrypi.inc | ||
| diff --git a/recipes-kernel/linux/linux-raspberrypi_5.10.bb b/recipes-kernel/linux/linux-raspberrypi_5.10.bb | ||
| index 8dade0b..41277bf 100644 | ||
| --- a/recipes-kernel/linux/linux-raspberrypi_5.10.bb | ||
| +++ b/recipes-kernel/linux/linux-raspberrypi_5.10.bb | ||
| @@ -12,6 +12,8 @@ SRC_URI = " \ | ||
| git://git.yoctoproject.org/yocto-kernel-cache;type=kmeta;name=meta;branch=${LINUX_RPI_KMETA_BRANCH};destsuffix=${KMETA} \ | ||
| file://powersave.cfg \ | ||
| file://android-drivers.cfg \ | ||
| + file://imx708-overlay.dts;subdir=git/arch/${ARCH}/boot/dts/overlays \ | ||
| + file://imx708-overlay.dtsi;subdir=git/arch/${ARCH}/boot/dts/overlays \ | ||
| " | ||
|
|
||
| require linux-raspberrypi.inc | ||
| -- | ||
| 2.34.1 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have been misunderstood. I was proposing to have this as a commit over the kernel source. Ideally, a formatted patch directly from rpi Linux kernel upstream. Does that make sense? Also, mind Upstream-status footer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, I expect: