Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use mainnet for ens resolution #232

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

cbrzn
Copy link
Contributor

@cbrzn cbrzn commented Apr 16, 2024

  • now we use mainnet for ENS resolution
  • ETHAddress class doesn't expect the Web3 instance in constructor argument
  • better support for native tokens and fill erc20 for L2 that have different native token/does not support uniswap

one thought is: should we explicitly add a warning if the address of the ENS is a smart contract? saying that the owner might not be the same in other network?

@cbrzn cbrzn requested review from dOrgJelli and nerfZael April 16, 2024 14:49
@nerfZael nerfZael merged commit 92d08a9 into main Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants