Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Transparent Navbar Update #612

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luizfboss
Copy link

Related Issue

Proposed Changes

  • Change 1
    Make the navbar transparent for a cleaner UI.

Additional Info

  • Any additional information or context
    Changes have been made to CSS files.

Checklist

  • ✅ My code follows the code style of this project.
  • 📝 My change requires a change to the documentation.
  • 🎀 I have updated the documentation accordingly.
  • 🌟 ed the repo
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Changes in the navbar's background color and its box shadow.

#595

Changes have been made in both .light and .dark CSS classes in assets/css/darkmode.css
In order to get a transparent navbar, the --bar variable in this file must have "transparent" as its value.

Additionally, it can be seen that when scrolling down, the navbar's box-shadow property creates a white smooth line that outlines the navbar, providing an unpleasant aesthetic on the page. This property has been removed from the CSS file.

This gives the impression of a cleaner UI. It feels like the screen gets bigger when scrolling through the page.

This does not affect any other piece of code in the repository.

Output Screenshots

Output (after changes)
output

Changes in navbar's background color, from #141d26 to transparent. This gives the impression of a less polluted and a cleaner UI. It feels like the screen gets bigger when scrolling down. Changes have been made in both .light and .dark CSS classes.

Additionally, it can be seen that when scrolling down, the navbar's box shadow gives an unpleasant contrast of colors, even though it is barely unnoticeable at first glance.
@netlify
Copy link

netlify bot commented Jul 22, 2023

Deploy Preview for codesetgo ready!

Name Link
🔨 Latest commit 46f8018
🔍 Latest deploy log https://app.netlify.com/sites/codesetgo/deploys/64bb497efa1c9c0008f80cd0
😎 Deploy Preview https://deploy-preview-612--codesetgo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@agamjotsingh18
Copy link
Owner

Hey, it wasn't assigned to you as other one raised issue before you, if her pr isn't good then will review yours ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants