Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing the user selected patterns #815

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Oct 24, 2023

Problem

  • The patterns selected by user are not installed because the package manager is reset before starting the installation and the selection is lot

Solution

  • Use the PackagesProposal module which remembers and restores the user selection
  • Then we do not need the local @user_patterns attribute to hold the user selected patterns because it is now stored in the PackagesProposal module

Testing

  • Tested manually, the selected patterns were installed

@coveralls
Copy link

Coverage Status

coverage: 75.072% (-0.01%) from 75.084% when pulling 59656e8 on fix_pattern_selection into 35b427c on master.

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lslezak lslezak merged commit 0d609c7 into master Oct 25, 2023
@lslezak lslezak deleted the fix_pattern_selection branch October 25, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants