-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): implement a new software service in Rust #1829
Draft
imobachgs
wants to merge
15
commits into
product-registration
Choose a base branch
from
software-service
base: product-registration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
changed the title
Software service
feat(rust): implement a new software service in Rust
Dec 12, 2024
imobachgs
force-pushed
the
software-service
branch
from
December 13, 2024 17:06
fab04dc
to
7a34d63
Compare
* Try to not rely on the generic ServiceError too much.
* It is expected to be used by our services (e.g., SoftwareService).
* The implementation is not 100% complete.
imobachgs
force-pushed
the
software-service
branch
from
December 13, 2024 17:07
7a34d63
to
2ccbed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This code is still a work in progress and so functionality is missing or temporary. The PR is open against the
product-registration
branch.This PR implements a new version of the software service using our libzypp bindings. The API is exposed through the
/api/software_ng
namespace, so it can coexist with the old software service.Architecture
This solution makes heavy use of channels. The software service is composed of two parts:
This approach is quite flexible, as the server is always running (so it could listen to other events) and processes one action at a time (it is hard to get into a deadlock), and it is fairly easy to reason about. The downside is that it requires some boilerplate code.
Note
I would like to experiment with a simpler approach based on mutexes, but it can wait a bit.
Tasks
ProductsRegistry
to handle the filters by architecture.alias
orname
to the list of repositories./probe
.probe
on a separate Task so it does not block (see the manager's example although it is not part of our codebase yet, but you get the idea)./proposal
./resolvables/:id
./patterns
)PUT /config
)./install
./issues
).