AG-11918 Allow preventing double click event on chart #2681
+60
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
requested changes
Oct 9, 2024
| @@ -42,6 +66,8 @@ export class Listeners<EventType extends string, EventHandler extends Handler> { | |||
| } catch (e) { | |||
| Logger.errorOnce(e); | |||
| } | |||
|
|
|||
| if (params.length === 1 && immediatePropagationStopped(params[0])) return; | |||
There was a problem hiding this comment.
Could you please clarify which specific handlers you are trying to stop calling? Intuitively, it might make more sense to just check the defaultPrevented property in the handlers that are causing problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
stopImmediatePropagationmethod for some events. This is slightly flaky as the registration order of listeners is important, but it does have precedent in web standards.Alternatively, we could make
seriesAreaManagerthe only module to callregionManager.listenAll, then other modules would callseriesAreaManager.addListener('click', ...), which would have the defaultPrevented logic already checked