Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): sort and filter review items #390

Merged
merged 25 commits into from
Jan 18, 2025
Merged

feat(ui): sort and filter review items #390

merged 25 commits into from
Jan 18, 2025

Conversation

davidlhw
Copy link
Contributor

@davidlhw davidlhw commented Jan 17, 2025 •
edited
Loading

Core Changes

New

  • add <RadioGroup/> shadcn component
  • add review item filter component
  • add review section list sort group component
  • break down review section into more manageable sub components (Section, Header, List, SortGroup, FilterGroup)

updates

  • rename <TagGroup/> to a more appropriately named <TagToggleGroup/>

Bug fixes

  • hide exposed mobile home button on screensize >= md
  • cypress e2e no longer uses auth api to get session. it logs in via ui instead

Implementation

  • Reviews are now filterable by ALL or UPVOTED
  • Reviews are now sortable by LATEST, TRENDING (to be properly defined, currently, tracking total number of review events on the review item), TOP VOTEs, TOP VIEWs

@davidlhw davidlhw linked an issue Jan 17, 2025 that may be closed by this pull request
allow sorting of reviews by rating, recency, trending #334
Closed
@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
afterclass-io-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 1:10pm

@davidlhw davidlhw marked this pull request as ready for review January 18, 2025 13:30
@davidlhw davidlhw merged commit 1619b14 into main Jan 18, 2025
7 checks passed
@davidlhw davidlhw deleted the 334 branch January 18, 2025 13:30
@davidlhw davidlhw added the enhancement New user-facing feature or request. This Label is used as a category on release notes. label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow sorting of reviews by rating, recency, trending
1 participant
@davidlhw