File Copy Implementation #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 68.92kb -> 55.78kb (19.06%) /Screenshot from 2020-07-12 13-30-51.png -- 42.47kb -> 30.83kb (27.4%) /app/src/main/res/mipmap-xxxhdpi/ic_launcher.png -- 10.40kb -> 9.54kb (8.33%) /app/src/main/res/mipmap-xxhdpi/ic_launcher.png -- 7.72kb -> 7.27kb (5.88%) /app/src/main/res/mipmap-hdpi/ic_launcher.png -- 3.51kb -> 3.43kb (2.14%) /app/src/main/res/mipmap-xhdpi/ic_launcher.png -- 4.81kb -> 4.71kb (2.07%) Signed-off-by: ImgBotApp <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Can you please add the reason why did you add |
…wnload directory when targetSdkVersion > 30 (Android 11)
[ImgBot] Optimize images
Fix bug: Storage permissions not required to save file in Download
|
You need merge this PR. As it's handle write external storage permission above Android 11 @afreakyelf |
afreakyelf
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Hi @rtsketo can you update your PR with latest changes please.
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Refinements:
WRITE_EXTERNAL_STORAGE, taking into account the different API levels and their permission models. This is critical for Android 6.0 (Marshmallow) and above, where runtime permissions are required.copyFile(..). This addresses a need to manipulate files within the app's scope effectively, following best practices for file storage.downloadFile(..)function has been improved to use Environment.getExternalStoragePublicDirectory(), which is a more standardized way to access shared storage in a manner consistent with Android's scoped storage model.Code Cleanup:
Gradle Updates:
Manifest Adjustments:
Visual Assets: