Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default maxCanvasWidth/Height to -1 (no max) #5440

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

mrxz
Copy link
Contributor

@mrxz mrxz commented Jan 26, 2024

Description:
As mentioned in #5413 the current default max width/height of 1920 is counter-intuitive. Most users are likely unaware of this default limit and they (or their users) will likely run into it once they notices a blurry and/or pixelated output on high resolution or oddly dimensioned displays. Especially with >1920x1080 resolutions becoming commonplace the limit is better removed IMO.

This PR only changes the default, the mechanism for limiting the resolution is still in place. Ultimately the logic might be removed entirely, but in its place we should probably expose the renderer's pixelRatio option to allow users to reduce the render resolution.

Changes proposed:

  • Change the default maxCanvasWidth/Height to -1

@dmarcos
Copy link
Member

dmarcos commented Jan 26, 2024

Thanks!

@dmarcos dmarcos merged commit c5bab4c into aframevr:master Jan 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants