Change default maxCanvasWidth/Height to -1 (no max) #5440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As mentioned in #5413 the current default max width/height of 1920 is counter-intuitive. Most users are likely unaware of this default limit and they (or their users) will likely run into it once they notices a blurry and/or pixelated output on high resolution or oddly dimensioned displays. Especially with >1920x1080 resolutions becoming commonplace the limit is better removed IMO.
This PR only changes the default, the mechanism for limiting the resolution is still in place. Ultimately the logic might be removed entirely, but in its place we should probably expose the renderer's
pixelRatio
option to allow users to reduce the render resolution.Changes proposed:
maxCanvasWidth/Height
to -1