Busser and transport enhancements

[muratiakos]

Hi Salim,

We started utilizing test-kitchen and kitchen-ec2 quite heavily, as it makes our job so much easier to test and verify our Windows cookbooks properly in Amazon. So here's my new batch of contribution for the Windows / WinRm support to your review - this time for test-kitchen. :)

The main change is that - I've realized during kitchen verify executions, that busser_sync method is responsible for pushing the test files, which breaks with WinRM, if the test files are getting larger - due to the command length limitations of the WinRM service. So my idea was to move them with the standard transport layer (both for ssh and winrm) and let busser_sync only do the preparation on the already transported files from a temp folder.

The changes namely:

• Added a file-transfer phase for busser to push files via the regular transport layer (both SSH and WinRM) with the help of temporary transport folders
• Improved reliability for MD5 hash checks via WinRM by passing ExitCodes through outputs too for PS backward compatibility, as winrm can't always capture the code after Exit command
  • Improved busser cleanup to make kitchen setup repeatable by removing and reinstalling plugins
  • Added SSH key to transport configuration for backward compatibility of old .kitchen.yml ssh_key attributes

I've tested the changes both with SSH and WinRM. Thank you again for your work and of course for your time reviewing this! :)

Have a great day and Regards,
Akos