AYS-551 | The Email Validation Fixed.

[MenekseYuncu]

Checklist

Before submitting your pull request, ensure the following:

• Title and Branch Naming Conventions:

  • The pull request title follows the
    standard: Pull Request Naming Conventions.
  • The branch name follows one of the conventions outlined in
    the Branch Naming Conventions.

• Local Testing:

  • I have tested my changes locally on Postman, and they are working as expected.

• Code Quality:

  • The code is formatted according to the project's coding guidelines and style.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.

• Documentation:

  • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.

• Testing:

  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.

• Reviewers and Assignees:

  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.

• Labels and Associations:

  • No specific actions are required in the Labels and Associations section for this pull request.

[agitrubard]

Suggested change

	if (email.startsWith(" ") || email.endsWith(" ")) {
	return buildViolation(constraintValidatorContext, "email must not start or end with whitespace.");
	}
	if (email.chars().filter(ch -> ch == '@').count() != 1) {
	return buildViolation(constraintValidatorContext, "email must contain exactly one '@' character.");
	}
	if (email.matches(".*[()#\\[\\]\";,\\s].*")) {
	return buildViolation(constraintValidatorContext, "email contains invalid special characters.");
	}
	String[] parts = email.split("@", 2);
	if (!Character.isLetterOrDigit(parts[0].charAt(0))) {
	return buildViolation(constraintValidatorContext, "email local part must start with a letter or number.");
	}
	String domainPart = parts[1];
	if (domainPart.startsWith("-") || domainPart.endsWith("-")) {
	return buildViolation(constraintValidatorContext, "domain must not start or end with a hyphen.");
	}
	if (!email.matches(EMAIL_REGEX)) {
	return buildViolation(constraintValidatorContext, "email is not in a valid format.");
	}
	if (email.startsWith(" ") || email.endsWith(" ")) {
	return this.buildViolation(constraintValidatorContext, "email must not start or end with whitespace");
	}
	if (email.chars().filter(ch -> ch == '@').count() != 1) {
	return this.buildViolation(constraintValidatorContext, "email must contain exactly one '@' character");
	}
	if (email.matches(".*[()#\\[\\]\";,\\s].*")) {
	return this.buildViolation(constraintValidatorContext, "email contains invalid special characters");
	}
	String[] parts = email.split("@", 2);
	if (!Character.isLetterOrDigit(parts[0].charAt(0))) {
	return this.buildViolation(constraintValidatorContext, "email local part must start with a letter or number");
	}
	String domainPart = parts[1];
	if (domainPart.startsWith("-") || domainPart.endsWith("-")) {
	return this.buildViolation(constraintValidatorContext, "domain must not start or end with a hyphen");
	}
	if (!email.matches(EMAIL_REGEX)) {
	return this.buildViolation(constraintValidatorContext, "email is not in a valid format");
	}

[agitrubard]

Suggested change

	private boolean buildViolation(ConstraintValidatorContext context, String message) {
	context.disableDefaultConstraintViolation();
	context.buildConstraintViolationWithTemplate(message).addConstraintViolation();
	return false;
	}
	private boolean buildViolation(ConstraintValidatorContext constraintValidatorContext, String message) {
	constraintValidatorContext.disableDefaultConstraintViolation();
	constraintValidatorContext.buildConstraintViolationWithTemplate(message).addConstraintViolation();
	return false;
	}

[agitrubard]

Suggested change

	return this.buildViolation(constraintValidatorContext, "email must not start or end with whitespace");
	}
	if (email.chars().filter(ch -> ch == '@').count() != 1) {
	return this.buildViolation(constraintValidatorContext, "email must contain exactly one '@' character");
	}
	if (email.matches(".*[()#\\[\\]\";,\\s].*")) {
	return this.buildViolation(constraintValidatorContext, "email contains invalid special characters");
	}
	String[] parts = email.split("@", 2);
	if (!Character.isLetterOrDigit(parts[0].charAt(0))) {
	return this.buildViolation(constraintValidatorContext, "email local part must start with a letter or number");
	}
	String domainPart = parts[1];
	if (domainPart.startsWith("-") || domainPart.endsWith("-")) {
	return this.buildViolation(constraintValidatorContext, "domain must not start or end with a hyphen");
	}
	if (!email.matches(EMAIL_REGEX)) {
	return this.buildViolation(constraintValidatorContext, "email is not in a valid format");
	}
	return this.buildViolation(constraintValidatorContext, "must not start or end with whitespace");
	}
	if (email.chars().filter(ch -> ch == '@').count() != 1) {
	return this.buildViolation(constraintValidatorContext, "must contain exactly one '@' character");
	}
	if (email.matches(".*[()#\\[\\]\";,\\s].*")) {
	return this.buildViolation(constraintValidatorContext, "contains invalid special characters");
	}
	String[] parts = email.split("@", 2);
	if (!Character.isLetterOrDigit(parts[0].charAt(0))) {
	return this.buildViolation(constraintValidatorContext, "local part must start with a letter or number");
	}
	String domainPart = parts[1];
	if (domainPart.startsWith("-") || domainPart.endsWith("-")) {
	return this.buildViolation(constraintValidatorContext, "domain must not start or end with a hyphen");
	}
	if (!email.matches(EMAIL_REGEX)) {
	return this.buildViolation(constraintValidatorContext, "must be valid format");
	}

[agitrubard]

Buradaki mesajların geleceğine dair testleri göremedim. Her bir mesajı ayrı ayrı böldüğümüz için bence bu senaryolar için de testler eklemeliyiz.