Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#163 | Fixed response type of search assignment endpoint #167

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

ibrahimdenizz
Copy link
Contributor

PULL REQUEST TEMPLATE

Description

I added location field instead of longitude and latitude fields in AssignmentSearchResponse and updated mapper of AssignmentSearchResponse.

Related Issue

#163

Proposed Changes

Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.

  • Branches should follow the below Naming Conventions of Branchs header in README.md File

Additional Information

If there's any additional information or context that the reviewers should know, please provide it here.

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@ibrahimdenizz ibrahimdenizz linked an issue Sep 7, 2023 that may be closed by this pull request
@ibrahimdenizz ibrahimdenizz self-assigned this Sep 7, 2023
Copy link
Collaborator

@skayikci skayikci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@agitrubard agitrubard merged commit e002549 into main Sep 12, 2023
1 check passed
@agitrubard agitrubard deleted the bugfix/163/assignment-search-response branch September 12, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atama Arama Servis Cevabının Güncellenmesi
4 participants