Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#93 | Implementation of 'Assignment Listing' API Endpoint #160

Merged
merged 48 commits into from
Sep 8, 2023
Merged

#93 | Implementation of 'Assignment Listing' API Endpoint #160

merged 48 commits into from
Sep 8, 2023

Conversation

AhmetAksunger
Copy link
Contributor

@AhmetAksunger AhmetAksunger commented Sep 1, 2023 •
edited
Loading

PULL REQUEST TEMPLATE

Description

Implemented the process of listing assignments by institution id and the specified filters.

Related Issue

#93

Proposed Changes

Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.

  • Branches should follow the below Naming Conventions of Branchs header in README.md File

Additional Information

Important

An issue should be created for the validation of the fields: statuses & phoneNumber.

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@AhmetAksunger
Update SuppressWarnings description
98646ef
@AhmetAksunger
Update AssignmentListRequest
625cc4b
@AhmetAksunger
Removed Assignment Search Response from the AssignmentResponse
14d0888
@AhmetAksunger
Define AssignmentsResponse
c9b1567
@AhmetAksunger
Define getAssignments in AssignmentController
dbfcbb4
@AhmetAksunger
Add JavaDoc for getAssignments method
6f28d9a
@AhmetAksunger
Define getAssignments in AssignmentService
f9cbacf
@AhmetAksunger
Implement getAssignments in AssignmentServiceImpl
00fe7f6
@AhmetAksunger
Replacing statement lambda with expression lambda in AssignmentServic…
3813c83 
…eImpl
@AhmetAksunger
JavaDoc for the getAssignments method in AssignmentServiceImpl
13120cd
@AhmetAksunger
Create AssignmentToAssignmentsResponseMapper
db93be9
@AhmetAksunger
Update initialize method in AssignmentToAssignmentsResponseMapper
08b4f64
@AhmetAksunger
Add lombok constructors to AssignmentListRequest & Filter
bae463c
@AhmetAksunger
Update AssignmentToAssignmentsResponseMapper
6e8054b
@AhmetAksunger
Add Getter & Setter for the inner classes in AssignmentsResponse
cbe3c0c
@AhmetAksunger
Update getAssignments in AssignmentController
7871f43
@AhmetAksunger
Add phoneNumber filter to AssignmentListRequest
21b1836
@AhmetAksunger
Implement the phoneNumber filter in AssignmentServiceImpl
cfa373a
@AhmetAksunger
Update JavaDoc for getAssignments
e26493b
@AhmetAksunger
Add if status empty check
62efd39
@AhmetAksunger
Fixed typo
ac64228
@AhmetAksunger
Create AssignmentListRequestBuilder
50adc5b
@AhmetAksunger
Update AssignmentListRequestBuilder
4260cae
@AhmetAksunger
Handled givenAssignmentListRequest_whenAssignmentStatusIsAvailable_th…
88aebbc 
…enReturnAysPageAssignmentResponse
@AhmetAksunger
Handled givenAssignmentListRequest_whenPhoneNumberIsAvailable_thenRet…
dfe780d 
…urnAysPageAssignmentResponse & givenAssignmentListRequest_whenAssignmentStatusAndPhoneNumberAvailable_thenReturnAysPageAssignmentResponse
@AhmetAksunger
Add isEmpty check for the fields countryCode & lineNumber in Assignme…
f513901 
…ntListRequest - toSpecification
@AhmetAksunger
Handle givenValidAssignmentListRequest_whenAssignmentsFound_thenRetur…
9360480 
…nAysPageResponseOfAssignmentsResponse
@AhmetAksunger
Handled givenValidAssignmentListRequest_whenUserUnauthorizedForListin…
62d3a53 
…g_thenReturnAccessDeniedException
@AhmetAksunger
Changed GET to POST in the method "getAssignments"
ca3a547
@AhmetAksunger
Resolved the latitude & longitude mistake
9a4fdc7
@agitrubard agitrubard removed feature New feature or request in review This issue in review labels Sep 4, 2023
@agitrubard
Merge remote-tracking branch 'origin/main' into feature/93/get-assign…
d3052b0 
…ments

# Conflicts:
#	src/main/java/com/ays/assignment/controller/AssignmentController.java
#	src/main/java/com/ays/assignment/model/mapper/AssignmentToAssignmentResponseMapper.java
#	src/test/java/com/ays/assignment/controller/AssignmentControllerTest.java
#	src/test/java/com/ays/assignment/controller/AssignmentSystemTest.java
@AhmetAksunger
Copy link
Contributor Author

  • Dönen cevaba assignment status eklenmeli
  • AysPhoneNumber objesi yerine bir inner class yazılıp @Digit anotasyonuyla valide edilmeli

agitrubard
agitrubard requested changes Sep 6, 2023
View reviewed changes
src/main/java/com/ays/assignment/model/dto/request/AssignmentListRequest.java Show resolved Hide resolved
src/main/java/com/ays/assignment/model/dto/request/AssignmentListRequest.java Show resolved Hide resolved
src/main/java/com/ays/assignment/model/dto/request/AssignmentListRequest.java Outdated Show resolved Hide resolved
src/main/java/com/ays/assignment/model/dto/request/AssignmentListRequest.java Outdated Show resolved Hide resolved
src/main/java/com/ays/assignment/model/dto/request/AssignmentListRequest.java Outdated Show resolved Hide resolved
src/test/java/com/ays/assignment/service/impl/AssignmentServiceImplTest.java Show resolved Hide resolved
src/test/java/com/ays/assignment/service/impl/AssignmentServiceImplTest.java Show resolved Hide resolved
src/test/java/com/ays/assignment/service/impl/AssignmentServiceImplTest.java Show resolved Hide resolved
src/test/java/com/ays/assignment/service/impl/AssignmentServiceImplTest.java Show resolved Hide resolved
src/test/java/com/ays/assignment/service/impl/AssignmentServiceImplTest.java Outdated Show resolved Hide resolved
agitrubard
agitrubard previously approved these changes Sep 7, 2023
View reviewed changes
@AhmetAksunger
Merge remote-tracking branch 'origin/main' into feature/93/get-assign…
64d9b7b 
…ments

# Conflicts:
#	src/main/java/com/ays/assignment/model/mapper/AssignmentToAssignmentResponseMapper.java
#	src/main/java/com/ays/assignment/service/impl/AssignmentServiceImpl.java
#	src/test/java/com/ays/assignment/service/impl/AssignmentServiceImplTest.java
Rapter1990
Rapter1990 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Rapter1990 Rapter1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Rapter1990 Rapter1990 merged commit 5aecf16 into main Sep 8, 2023
1 check passed
@Rapter1990 Rapter1990 deleted the feature/93/get-assignments branch September 8, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moaydogdu moaydogdu moaydogdu approved these changes

@Rapter1990 Rapter1990 Rapter1990 approved these changes

@skayikci skayikci Awaiting requested review from skayikci skayikci is a code owner

@ibrahimdenizz ibrahimdenizz Awaiting requested review from ibrahimdenizz

@ilkerCelimli ilkerCelimli Awaiting requested review from ilkerCelimli

@agitrubard agitrubard Awaiting requested review from agitrubard agitrubard is a code owner

Assignees

@Rapter1990 Rapter1990

@AhmetAksunger AhmetAksunger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atama Listeleme Servisinin Hazırlanması
4 participants
@AhmetAksunger @Rapter1990 @agitrubard @moaydogdu