Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#95 | Implement the process of searching Assignment by location #159

Merged
merged 20 commits into from
Sep 5, 2023
Merged

#95 | Implement the process of searching Assignment by location #159

merged 20 commits into from
Sep 5, 2023

Conversation

ibrahimdenizz
Copy link
Contributor

@ibrahimdenizz ibrahimdenizz commented Aug 31, 2023 •
edited by agitrubard
Loading

PULL REQUEST TEMPLATE

Description

Imploement the process of searching Assignment by location

Related Issue

#95

Proposed Changes

Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.

  • Branches should follow the below Naming Conventions of Branchs header in README.md File

Additional Information

If there's any additional information or context that the reviewers should know, please provide it here.

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@ibrahimdenizz
Add assignment/search endpoint
b2bd463
@ibrahimdenizz
Add findByPointAndInstitutionId to AssignmentRepository
19a15fb
@ibrahimdenizz
Add assignment search service
dd185de
@ibrahimdenizz
Update search endpoint with service and update assignment response ma…
e3188c1 
…pper

I added assignmentSearchService and assignmentToAssignmentResponseMapper to AssignmentController.
I updated assignment search endpoint. It does not search assignment but gets by coordinates to test for now.
I added mappings for latitude and longitude fields.
@ibrahimdenizz
Update search query with sql command that find nearest assignment
3380894
@ibrahimdenizz
Add mapper for search response and refactor not exists exception
bcafb2f
@ibrahimdenizz
Fix coordinate parameters issue.
4c2d8a1 
The longitude wil be x-axis and latitude will be y-axis.
@ibrahimdenizz
Add control that checks whether user is ready.
ae01d15 
I added isReady method to UserEntity class. isReady checks is active and ready.
I added user status control searchAssignment method of AssignmentSearchService. This control checks whether user's support status is ready and user's status is active.
I added AysAssignmentUserNotReadyException exception to throw when the above control fails.
@ibrahimdenizz
Add assignment availability control and reserve assignment feature
d803fc7 
I added active status control to search assignment query.
I added reserve method to AssignmentEntity class.
I implemented findNearestAvailableAssignment and reserve method of AssigmentEntity.
@ibrahimdenizz
Add unit and integration test
3d56b56
@ibrahimdenizz
Add system tests and update first user's support status
e86c632
@ibrahimdenizz
Fix mock service method's parameter issue
17e0181
@ibrahimdenizz ibrahimdenizz self-assigned this Aug 31, 2023
@ibrahimdenizz ibrahimdenizz linked an issue Aug 31, 2023 that may be closed by this pull request
Atama Arama Servisinin Hazırlanması #95
Closed
@Rapter1990 Rapter1990 changed the title #95 | Imploement the process of searching Assignment by location #95 | Implement the process of searching Assignment by location Sep 1, 2023
@ibrahimdenizz
Merge branch 'main' into feature/95/user-assignment-search
bbeb172 
# Conflicts:
#	src/main/java/com/ays/assignment/controller/AssignmentController.java
#	src/main/java/com/ays/assignment/repository/AssignmentRepository.java
#	src/test/java/com/ays/assignment/controller/AssignmentControllerTest.java
#	src/test/java/com/ays/assignment/controller/AssignmentSystemTest.java
@Rapter1990 Rapter1990 added feature New feature or request review required This issue is must be review in review This issue in review and removed review required This issue is must be review labels Sep 2, 2023
Rapter1990
Rapter1990 previously approved these changes Sep 3, 2023
View reviewed changes
Copy link
Contributor

@Rapter1990 Rapter1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

artfulCoder98
artfulCoder98 previously approved these changes Sep 3, 2023
View reviewed changes
AhmetAksunger
AhmetAksunger previously approved these changes Sep 3, 2023
View reviewed changes
@agitrubard agitrubard dismissed stale reviews from artfulCoder98, Rapter1990, and AhmetAksunger September 3, 2023 15:53

Yorumlarım var, mergelenmesin diye approve'ları kaldırdım bilginize.

@ibrahimdenizz
Remove redundant new lines and update search service implementation's…
f31cb60 
… access
@ibrahimdenizz
Add fourth user has supportStatus READY for system tests
2cd8a8c 
I Added fourth user has supportStatus READY in second database changes (`2-ays-dml.xml`).
Then, I added fourth user token to use assignment search system test
@ilkerCelimli ilkerCelimli self-requested a review September 3, 2023 17:47
ilkerCelimli
ilkerCelimli previously approved these changes Sep 3, 2023
View reviewed changes
emreylmaz
emreylmaz approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@emreylmaz emreylmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Rapter1990
Rapter1990 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Rapter1990 Rapter1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agitrubard agitrubard merged commit 63f984b into main Sep 5, 2023
1 check passed
@agitrubard agitrubard deleted the feature/95/user-assignment-search branch September 5, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilhazar anilhazar anilhazar approved these changes

@agitrubard agitrubard agitrubard approved these changes

@emreylmaz emreylmaz emreylmaz approved these changes

@Rapter1990 Rapter1990 Rapter1990 approved these changes

@skayikci skayikci skayikci approved these changes

@artfulCoder98 artfulCoder98 artfulCoder98 left review comments

@AhmetAksunger AhmetAksunger AhmetAksunger left review comments

@ilkerCelimli ilkerCelimli ilkerCelimli left review comments

@enig enig Awaiting requested review from enig

Assignees

@ibrahimdenizz ibrahimdenizz

Labels
feature New feature or request in review This issue in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Atama Arama Servisinin Hazırlanması
9 participants
@ibrahimdenizz @skayikci @Rapter1990 @emreylmaz @agitrubard @ilkerCelimli @anilhazar @AhmetAksunger @artfulCoder98