Removed call to adjustTime() between calls to setTime() and hour(). #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes occasional failure to reflect time zone (HoursOffset) after updating the time from GPS. The Time library contains a refreshCache() function that updates the cache only if the time has changed since the last cache update. adjustTime does not call refreshCache(). hour() does call it, with the current time. If the current time is the same as the cached time from the setTime() call, then the cache of tm is not updated to reflect the adjustTime() call. Then, the timezone adjustment is ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes occasional failure to reflect time zone (HoursOffset)
after updating the time from GPS. The Time library contains a
refreshCache() function that updates the cache only if the time
has changed since the last cache update.
adjustTime does not call refreshCache(). hour() does call it, with
the current time. If the current time is the same as the cached time
from the setTime() call, then the cache of tm is not updated to reflect
the adjustTime() call. Then, the timezone adjustment is ignored.