Skip to content

Commit

Permalink
Merge branch '179-a-crash-may-be-caused-by-libcurl-when-executing-a-r…
Browse files Browse the repository at this point in the history
…equest-from-the-http-worker' into 'master'

Resolve "A crash may be caused by libcurl when executing a request from the HTTP worker"

Closes #179

See merge request aerys/smartshape-engine!176

(cherry picked from commit f069709)

af82e75 Set the libcurl option CURLOPT_NOSIGNAL on every request made to fix #179.
  • Loading branch information
Thomas Ville authored and jpx committed Jun 13, 2019
1 parent e5a0d94 commit 1120fa4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions plugin/http-worker/src/minko/net/HTTPRequest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ createCurl(const std::string& url,
if (!verifyPeer)
curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);

// https://git.aerys.in/aerys/smartshape-engine/issues/179
// https://stackoverflow.com/a/10755612/7512344
curl_easy_setopt(curl, CURLOPT_NOSIGNAL, 1);

// POST method
if (!postFields.empty())
{
Expand Down

0 comments on commit 1120fa4

Please sign in to comment.