Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of RaptureGearsetModule.UpdateGearset #1096

Closed

Conversation

Haselnussbomber
Copy link
Contributor

The function returns error codes (-1 or -2) or the gearset id if successful.
If the function returns anything under -1, the gearset list will refresh and scroll up (which is the issue I'm facing right now).

Copy link
Contributor

Breaking Changes

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Client.UI.Misc.RaptureGearsetModule.Delegates: 1

UpdateGearset: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.UI.Misc.RaptureGearsetModule*, int)
  • void EndInvoke(System.IAsyncResult)

FFXIVClientStructs.FFXIV.Client.UI.Misc: 1

RaptureGearsetModule: 1

  • void UpdateGearset(int)

@github-actions github-actions bot added the breaking change PR contains breaking changes and wont be merged before a new patch label Aug 17, 2024
@Haselnussbomber Haselnussbomber changed the title Update return type of RaptureGearsetModule.UpdateGearset Fix return type of RaptureGearsetModule.UpdateGearset Aug 17, 2024
@Haselnussbomber Haselnussbomber deleted the update-updategearset branch August 18, 2024 11:59
@Haselnussbomber
Copy link
Contributor Author

Moved to #1089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change PR contains breaking changes and wont be merged before a new patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant