Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1500 Add validation for ASBX restore configuration #217

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

filkeith
Copy link
Contributor

@filkeith filkeith commented Feb 3, 2025

  • added restore config validation for asbx
  • fixed documentation

- added restore config validation for asbx
- fixed documentation
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 43.33333% with 34 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (87e1c5b) to head (e4c66b3).

Files with missing lines Patch % Lines
cmd/internal/app/asrestore.go 0.00% 31 Missing ⚠️
client.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           xdr-support     #217      +/-   ##
===============================================
- Coverage        78.67%   78.58%   -0.09%     
===============================================
  Files              110      110              
  Lines            10031    10079      +48     
===============================================
+ Hits              7892     7921      +29     
- Misses            1642     1660      +18     
- Partials           497      498       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filkeith filkeith requested a review from reugn February 3, 2025 11:45
@reugn reugn changed the title APPS-1500 Restore config validation for ASBX APPS-1500 Add validation for ASBX restore configuration Feb 3, 2025
- don't start asbx if no asbx files found in directory
- text fixes
@filkeith filkeith merged commit d6bfe30 into xdr-support Feb 3, 2025
4 checks passed
@filkeith filkeith deleted the APPS-1500-restore-config-validation branch February 3, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants