Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-653 Fix restore duration in reports #215

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

filkeith
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (1328051) to head (fade819).

Files with missing lines Patch % Lines
cmd/internal/app/reports.go 76.59% 11 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           xdr-support     #215      +/-   ##
===============================================
- Coverage        78.39%   78.34%   -0.06%     
===============================================
  Files              110      110              
  Lines             9999    10017      +18     
===============================================
+ Hits              7839     7848       +9     
- Misses            1654     1663       +9     
  Partials           506      506              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filkeith filkeith requested a review from reugn January 30, 2025 14:10
cmd/internal/app/reports.go Outdated Show resolved Hide resolved
@reugn reugn changed the title FMWK-653 Fix reports timing FMWK-653 Fix restore duration in reports Jan 30, 2025
@filkeith filkeith requested a review from reugn January 30, 2025 15:22
@filkeith filkeith merged commit fbb8277 into xdr-support Jan 30, 2025
4 checks passed
@filkeith filkeith deleted the FMWK-653-fix-reports-timing branch January 30, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants