Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3324] Add "commit_status" and "abort_status" attributes to AerospikeError exceptions #721

Merged
merged 27 commits into from
Feb 12, 2025

Conversation

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (c76bc84) to head (9dfda9f).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #721      +/-   ##
==========================================
+ Coverage   81.09%   81.12%   +0.02%     
==========================================
  Files         102      102              
  Lines       15203    15213      +10     
==========================================
+ Hits        12329    12341      +12     
+ Misses       2874     2872       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-3324] Include commit or abort status in exception raised by abort() or commit(), respectively [CLIENT-3324] Add "commit_status" and "abort_status" attributes to AerospikeError exceptions Feb 6, 2025
@juliannguyen4 juliannguyen4 marked this pull request as ready for review February 12, 2025 15:06
dwelch-spike
dwelch-spike previously approved these changes Feb 12, 2025
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliannguyen4 juliannguyen4 merged commit 2bad34c into dev Feb 12, 2025
41 of 42 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3324-exc-commit-status branch February 12, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants