[CLIENT-3205] Multi record transactions: support correct server error codes for MRTs #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannguyen4
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #701 +/- ##
==========================================
+ Coverage 80.89% 81.05% +0.15%
==========================================
Files 102 102
Lines 15186 15187 +1
==========================================
+ Hits 12285 12310 +25
+ Misses 2901 2877 -24 ☔ View full report in Codecov by Sentry. |
juliannguyen4
changed the title
juliannguyen4
changed the title
justinlee-aerospike
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra changes:
CLIENT-3199 Do not close/delete MRT monitor record on abort/commit when a write command in that MRT fails and is in doubt
CLIENT-3212 Raise TranactionFailed exception instead of BatchFailed exception when batch MRT verify fails.
Unlock macOS keychain on self-hosted macOS runners to prevent workflow from failing
Valgrind tests look fine
Build artifacts looks ok