Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3166] Fix AerospikeError attributes not being assigned when an error code without a matching Exception is raised #694

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Nov 18, 2024

  • build artifacts passes
  • valgrind passes
  • massif performance looks good

Extra changes:

  • AerospikeError.in_doubt should always be set as an attribute, even if an AerospikeError was not raised by the client yet

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.77%. Comparing base (a46024d) to head (3b1b888).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/client/info.c 0.00% 3 Missing ⚠️
src/main/exception.c 80.00% 2 Missing ⚠️
src/main/client/sec_index.c 50.00% 1 Missing ⚠️
src/main/scan/apply.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #694      +/-   ##
==========================================
- Coverage   80.79%   80.77%   -0.02%     
==========================================
  Files         102      102              
  Lines       15173    15185      +12     
==========================================
+ Hits        12259    12266       +7     
- Misses       2914     2919       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@juliannguyen4 juliannguyen4 changed the title [CLIENT-3166] Fix AerospikeError attributes not being assigned when an unknown error code is raised [CLIENT-3166] Fix AerospikeError attributes not being assigned when an error code without a matching Exception is raised Nov 21, 2024
@juliannguyen4 juliannguyen4 marked this pull request as ready for review November 21, 2024 19:44
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but think about abstracting the block of exception handling code that set_aerospike_exc_attrs_using_tuple_of_attrs is used in into something reusable.

src/main/client/apply.c Show resolved Hide resolved
@juliannguyen4 juliannguyen4 merged commit 8d941e5 into dev Nov 21, 2024
126 of 132 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3166-fix-missing-exc-attrs-for-unknown-codes branch November 21, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants