-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-3166] Fix AerospikeError attributes not being assigned when an error code without a matching Exception is raised #694
[CLIENT-3166] Fix AerospikeError attributes not being assigned when an error code without a matching Exception is raised #694
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #694 +/- ##
==========================================
- Coverage 80.79% 80.77% -0.02%
==========================================
Files 102 102
Lines 15173 15185 +12
==========================================
+ Hits 12259 12266 +7
- Misses 2914 2919 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but think about abstracting the block of exception handling code that set_aerospike_exc_attrs_using_tuple_of_attrs
is used in into something reusable.
Extra changes: