Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2417] Only set as_partition_filter.as_partitions_status to a non-NULL value when set by the user in Python #683

Draft
wants to merge 43 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Oct 15, 2024

…n python

  • All the test cases in the test file test_scan_get_partitions_status.py are still in test_query_get_partitions_status.py, I believe
  • Valgrind memory leaks for get_partitions_status are gone

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (8ff0327) to head (277604e).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/convert_partition_filter.c 61.11% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #683      +/-   ##
==========================================
- Coverage   80.89%   80.68%   -0.22%     
==========================================
  Files         100      100              
  Lines       15053    14903     -150     
==========================================
- Hits        12177    12024     -153     
- Misses       2876     2879       +3     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants