Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2992] Add Python 3.13 support #629

Merged
merged 11 commits into from
Nov 21, 2024
Merged

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Jun 5, 2024

Stage tests are passing except noise
Build artifacts is passing

Issue https://github.com/aerospike/aerospike-client-python/actions/runs/11900398951/job/33161504592

3.13 tests are complaining about PyObject_HasAttrString() ignoring an exception being raised during it's call, and are recommending to replace them with newer API calls, but this behavior has always existed. We can address this in a future PR

QE builds work with 3.13 now

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (a46024d) to head (f880d4b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #629   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files         102      102           
  Lines       15173    15173           
=======================================
  Hits        12259    12259           
  Misses       2914     2914           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2992-python-3.13 branch from 08c9556 to 1aefe3b Compare October 1, 2024 15:58
@juliannguyen4 juliannguyen4 marked this pull request as ready for review November 20, 2024 16:53
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit b1b8ed0 into dev Nov 21, 2024
187 of 195 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2992-python-3.13 branch November 21, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants