Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2701] Fix memory leak that occurs when creating an aerospike_helpers class instance with a parameter #612

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Apr 30, 2024

Memory usage after running the full test suites is now back to normal as before the metrics changes. No memory errors from running valgrind on this branch

dev: https://github.com/aerospike/aerospike-client-python/actions/runs/8884233073
this branch: https://github.com/aerospike/aerospike-client-python/actions/runs/8897726512
Before metrics changes: https://github.com/aerospike/aerospike-client-python/actions/runs/8886114249

@juliannguyen4 juliannguyen4 marked this pull request as ready for review April 30, 2024 19:28
Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliannguyen4 juliannguyen4 merged commit c86ff63 into dev Apr 30, 2024
56 of 57 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2701-metrics-memleak branch April 30, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants