General cleanup/improvements

connection.go

@@ -134,3 +134,16 @@ func (ctn *Connection) Close() {
 		ctn.conn = nil
 	}
 }
+
+// Authenticate will send authentication information to the server.
+func (ctn *Connection) Authenticate(user string, password []byte) error {
+	// need to authenticate
+	if user != "" {
+		command := newAdminCommand()
+		if err := command.authenticate(ctn, user, password); err != nil {
+			// Socket not authenticated. Do not put back into pool.
+			return err
+		}
+	}
+	return nil
+}

node_validator.go

@@ -85,13 +85,12 @@ func (ndv *nodeValidator) setAddress(timeout time.Duration) error {
 		defer conn.Close()
 
 		// need to authenticate
-		if ndv.cluster.user != "" {
-			command := newAdminCommand()
-			if err := command.authenticate(conn, ndv.cluster.user, ndv.cluster.password); err != nil {
-				// Socket not authenticated. Do not put back into pool.
-				conn.Close()
-				return err
-			}
+		// need to authenticate
+		if conn.Authenticate(ndv.cluster.user, ndv.cluster.password); err != nil {
+			// Socket not authenticated. Do not put back into pool.
+			conn.Close()
+
+			return err
 		}
 
 		if err := conn.SetTimeout(timeout); err != nil {

value.go

@@ -225,7 +225,7 @@ func (vl BytesValue) GetType() int {
 
 // GetObject returns original value as an interface{}.
 func (vl BytesValue) GetObject() interface{} {
-	return vl
+	return []byte(vl)
 }
 
 // func (vl BytesValue) GetLuaValue() LuaValue {
@@ -271,7 +271,7 @@ func (vl StringValue) GetType() int {
 
 // GetObject returns original value as an interface{}.
 func (vl StringValue) GetObject() interface{} {
-	return vl
+	return string(vl)
 }
 
 // func (vl StringValue) GetLuaValue() LuaValue {
@@ -369,7 +369,7 @@ func (vl LongValue) GetType() int {
 
 // GetObject returns original value as an interface{}.
 func (vl LongValue) GetObject() interface{} {
-	return vl
+	return int64(vl)
 }
 
 // func (vl LongValue) GetLuaValue() LuaValue {

value_test.go

@@ -91,7 +91,7 @@ var _ = Describe("Value Test", func() {
 
 			bval := NewValue(person)
 			Expect(bval.GetType()).To(Equal(ParticleType.BLOB))
-			Expect(bval).To(BeAssignableToTypeOf(&BytesValue{}))
+			Expect(bval).To(BeAssignableToTypeOf(BytesValue{}))
 			Expect(bval.GetObject()).To(Equal([]byte(person.name)))
 		})
 	})