Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPS-1466 Add HTTP request logging middleware #317

Merged
merged 20 commits into from
Feb 4, 2025

Conversation

korotkov-aerospike
Copy link
Contributor

@korotkov-aerospike korotkov-aerospike commented Feb 3, 2025

Three main points in PR:

move away from gorilla mux
add logger for every request
add standartiszation for error handling in controller

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.74%. Comparing base (5715ec6) to head (d2fceb1).

Additional details and impacted files
@@            Coverage Diff             @@
##               v3     #317      +/-   ##
==========================================
+ Coverage   48.57%   48.74%   +0.16%     
==========================================
  Files          56       56              
  Lines        3162     3145      -17     
==========================================
- Hits         1536     1533       -3     
+ Misses       1460     1446      -14     
  Partials      166      166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korotkov-aerospike korotkov-aerospike marked this pull request as ready for review February 3, 2025 12:44
internal/server/middleware/logger.go Outdated Show resolved Hide resolved
internal/server/middleware/logger.go Outdated Show resolved Hide resolved
internal/server/middleware/logger.go Outdated Show resolved Hide resolved
internal/server/middleware/logger.go Outdated Show resolved Hide resolved
internal/server/middleware/logger.go Outdated Show resolved Hide resolved
internal/server/handlers/service.go Outdated Show resolved Hide resolved
@reugn reugn changed the title APPS-1466 Log rest requests APPS-1466 Add HTTP request logging middleware Feb 3, 2025
@korotkov-aerospike korotkov-aerospike merged commit eb2251d into v3 Feb 4, 2025
7 checks passed
@korotkov-aerospike korotkov-aerospike deleted the apps-1466-log-rest-request branch February 4, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants