refactoring, add note on execve

aerickson · Aug 7, 2024 · e00edde · e00edde
1 parent 257d861
commit e00edde
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/tf_authoritative_scanner/scanner.py b/tf_authoritative_scanner/scanner.py
@@ -6,7 +6,7 @@
 import argparse
 import os.path
 
-from tf_authoritative_scanner.util import _get_version
+from tf_authoritative_scanner.util import _get_version, remove_leading_trailing_newline
 
 
 class TFAuthoritativeScanner:
@@ -175,14 +175,6 @@ def run(self, paths):
             sys.exit(0)
 
 
-def remove_leading_trailing_newline(text):
-    if text.startswith("\n"):
-        text = text[1:]
-    if text.endswith("\n"):
-        text = text[:-1]
-    return text
-
-
 def print_tfas_banner():
     # return
     print(

diff --git a/tf_authoritative_scanner/wrapper.py b/tf_authoritative_scanner/wrapper.py
@@ -28,6 +28,7 @@ def run_tfas_and_terraform(self, args):
         print()
 
         # Replace the current process with `terraform` command
+        # - avoids subprocess' issues with delaying output
         os.execvp(full_cmd_list[0], full_cmd_list)
 
     def print_tfast_banner(self):