Skip to content

Commit

Permalink
work on coverage 99
Browse files Browse the repository at this point in the history
  • Loading branch information
aerickson committed Aug 7, 2024
1 parent 78edb7a commit da6a800
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 8 deletions.
3 changes: 1 addition & 2 deletions tf_authoritative_scanner/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@
import sys


# can raise FileNotFoundError if the file does not exist
def get_version(rel_path):
for line in read_path(rel_path).splitlines():
if line.startswith("__version__"):
delim = '"' if '"' in line else "'"
return line.split(delim)[1]
else:
raise RuntimeError("Unable to find version string.")


def read_path(rel_path):
Expand Down
40 changes: 34 additions & 6 deletions tf_authoritative_scanner/util_test.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,37 @@
import tf_authoritative_scanner.util as util

import tempfile
import os
import pytest

def test_remove_leading_trailing_newline():
assert util.remove_leading_trailing_newline("") == ""
assert util.remove_leading_trailing_newline("a") == "a"
assert util.remove_leading_trailing_newline("a\n") == "a"
assert util.remove_leading_trailing_newline("\na") == "a"
assert util.remove_leading_trailing_newline("a\nb") == "a\nb"

class TestUtil:
@pytest.fixture
def temp_dir_with_version_file(self):
temp_dir = tempfile.TemporaryDirectory()
version_file_path = os.path.join(temp_dir.name, "__init__.py")
with open(version_file_path, "w") as f:
f.write("__version__ = '4.3.9999'")
yield temp_dir.name
temp_dir.cleanup()

@pytest.fixture
def temp_empty_dir(self):
temp_dir = tempfile.TemporaryDirectory()
yield temp_dir.name
temp_dir.cleanup()

def test_remove_leading_trailing_newline(self):
assert util.remove_leading_trailing_newline("") == ""
assert util.remove_leading_trailing_newline("a") == "a"
assert util.remove_leading_trailing_newline("a\n") == "a"
assert util.remove_leading_trailing_newline("\na") == "a"
assert util.remove_leading_trailing_newline("a\nb") == "a\nb"

def test_get_version(self, temp_dir_with_version_file):
assert util.get_version(f"{temp_dir_with_version_file}/__init__.py") == "4.3.9999"

def test_get_version_empty_dir(self, temp_empty_dir):
# should raise an exception FileNotFoundError
with pytest.raises(FileNotFoundError):
util.get_version(f"{temp_empty_dir}/__init__.py")

0 comments on commit da6a800

Please sign in to comment.