Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tenant permissions for oidc disabled cluster #549

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Dec 30, 2024

Summary by CodeRabbit

  • New Features

    • Enhanced Kubernetes RBAC configuration for tenant with expanded permissions on apps.cozystack.io API group
  • Chores

    • Updated tenant application version from 1.6.4 to 1.6.5
    • Added specific commit reference for tenant package

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 30, 2024
Copy link
Contributor

coderabbitai bot commented Dec 30, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the tenant application's version from 1.6.4 to 1.6.5 across multiple files. Changes include modifying the version in the Chart.yaml, expanding the Role permissions in the tenant.yaml template to allow full access to resources in the apps.cozystack.io API group, and updating the versions_map to reflect the new version and a specific commit reference.

Changes

File Change Summary
packages/apps/tenant/Chart.yaml Version updated from 1.6.4 to 1.6.5
packages/apps/tenant/templates/tenant.yaml Added new Role rule with full permissions for apps.cozystack.io API group
packages/apps/versions_map Updated tenant package version from 1.6.4 HEAD to 1.6.4 3c9e50a4 and added 1.6.5 HEAD

Possibly related PRs

  • Feature/add sso roles #480: The version of the application in Chart.yaml was updated from 1.5.0 to 1.6.0, which is a similar version update to the main PR's change from 1.6.4 to 1.6.5.
  • fix kubeconfig #515: The version of the application in Chart.yaml was updated from 1.6.1 to 1.6.2, indicating a related version update process.
  • Fix super-admin role #516: The version of the application in Chart.yaml was updated from 1.6.1 to 1.6.2, which is another instance of a version update in the same file.
  • Refactor tenant RBAC rules #534: The version of the application in Chart.yaml was updated from 1.6.2 to 1.6.3, continuing the pattern of version updates in the same file.
  • Update dashboard to use Cozystack API #539: The version of the application in Chart.yaml was updated from 1.6.3 to 1.6.4, which is directly related to the versioning changes in the main PR.

Suggested labels

enhancement, size:M, lgtm

Suggested reviewers

  • klinch0

Poem

🐰 A version hop, a tiny leap,
Permissions bloom, secrets to keep
From 1.6.4 to 1.6.5 we soar
Cozystack's tenant opens a new door!
Hop, hop, hooray! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84f3ccc and 470975d.

📒 Files selected for processing (3)
  • packages/apps/tenant/Chart.yaml (1 hunks)
  • packages/apps/tenant/templates/tenant.yaml (1 hunks)
  • packages/apps/versions_map (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps kvaps merged commit f1e1145 into main Dec 30, 2024
2 checks passed
@kvaps kvaps deleted the tenant-fix-permissions branch December 30, 2024 08:46
@dosubot dosubot bot added the bug Something isn't working label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant