added custom client route to query the hub_id #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the route to pull from hosted config so it will be easier to modify the config file without having to access aws. requires cors and node-fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed the route to pull from hosted config so it will be easier to modify the config file without having to access aws. requires cors and node-fetch.
You will want to set up the repository with a ghpages host and change the line
const configUrl = 'https://colinfizgig.github.io/Custom-Hubs-Components/top-level-main-server/config.json';
to point to our aelatgt hosted version of config.json. The idea is that whoever can add scripts to the custom client can modify the config.json in order to add those scripts to their hub_id. That way we won't need access to the AWS top-level to make changes. Eventually we might make a component that can inject the config using Spoke in order to bypass the need for a top-level server.