Skip to content

Commit

Permalink
Temporarily remove removeEmptyAnswersFromResponse across the entire app
Browse files Browse the repository at this point in the history
  • Loading branch information
fongsean committed Nov 6, 2024
1 parent 374d115 commit 0939fa4
Show file tree
Hide file tree
Showing 5 changed files with 33 additions and 39 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,7 @@ import parse from 'html-react-parser';
import { qrToHTML } from '../../../preview/utils/preview.ts';
import { Helmet } from 'react-helmet';
import PageHeading from '../../../dashboard/components/DashboardPages/PageHeading.tsx';
import {
removeEmptyAnswersFromResponse,
useQuestionnaireResponseStore,
useQuestionnaireStore
} from '@aehrc/smart-forms-renderer';
import { useQuestionnaireResponseStore, useQuestionnaireStore } from '@aehrc/smart-forms-renderer';

function FormPreview() {
const sourceQuestionnaire = useQuestionnaireStore.use.sourceQuestionnaire();
Expand All @@ -39,8 +35,13 @@ function FormPreview() {
return <FormInvalid />;
}

const cleanResponse = removeEmptyAnswersFromResponse(sourceQuestionnaire, updatableResponse);
const parsedHTML = parse(qrToHTML(sourceQuestionnaire, cleanResponse));
// Temporarily comment out this line to avoid saving errors
// const cleanResponse = removeEmptyAnswersFromResponse(
// questionnaire,
// updatableResponse
// );

const parsedHTML = parse(qrToHTML(sourceQuestionnaire, updatableResponse));

return (
<>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,7 @@ import {
} from '@mui/material';
import { saveQuestionnaireResponse } from '../../../../api/saveQr.ts';
import { LoadingButton } from '@mui/lab';
import {
removeEmptyAnswersFromResponse,
useQuestionnaireResponseStore,
useQuestionnaireStore
} from '@aehrc/smart-forms-renderer';
import { useQuestionnaireResponseStore, useQuestionnaireStore } from '@aehrc/smart-forms-renderer';
import useSmartClient from '../../../../hooks/useSmartClient.ts';

export interface Props {
Expand Down Expand Up @@ -77,8 +73,13 @@ function BlockerUnsavedFormDialog(props: Props) {

setIsSaving(true);

let responseToSave = structuredClone(updatableResponse);
responseToSave = removeEmptyAnswersFromResponse(sourceQuestionnaire, responseToSave);
const responseToSave = structuredClone(updatableResponse);

// Temporarily comment out this line to avoid saving errors
// responseToSave = removeEmptyAnswersFromResponse(
// questionnaire,
// responseToSave
// );

setIsSaving(true);
responseToSave.status = 'in-progress';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,7 @@

import { useEffect } from 'react';
import { Dialog, DialogContent, DialogContentText, DialogTitle } from '@mui/material';
import {
removeEmptyAnswersFromResponse,
useQuestionnaireResponseStore,
useQuestionnaireStore
} from '@aehrc/smart-forms-renderer';
import { useQuestionnaireResponseStore, useQuestionnaireStore } from '@aehrc/smart-forms-renderer';
import { saveQuestionnaireResponse } from '../../../api/saveQr.ts';
import { useSnackbar } from 'notistack';
import useSmartClient from '../../../hooks/useSmartClient.ts';
Expand Down Expand Up @@ -54,10 +50,13 @@ function AutoSaveDialog(props: AutoSaveDialogProps) {
return;
}

const responseToSave = removeEmptyAnswersFromResponse(
sourceQuestionnaire,
structuredClone(updatableResponse)
);
// Temporarily comment out this line to avoid saving errors
// const responseToSave = removeEmptyAnswersFromResponse(
// questionnaire,
// structuredClone(updatableResponse)
// );

const responseToSave = structuredClone(updatableResponse);

responseToSave.status = 'in-progress';
saveQuestionnaireResponse(smartClient, patient, user, sourceQuestionnaire, responseToSave)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,7 @@ import {
Tooltip
} from '@mui/material';
import { LoadingButton } from '@mui/lab';
import {
removeEmptyAnswersFromResponse,
useQuestionnaireResponseStore,
useQuestionnaireStore
} from '@aehrc/smart-forms-renderer';
import { useQuestionnaireResponseStore, useQuestionnaireStore } from '@aehrc/smart-forms-renderer';
import ReadMoreIcon from '@mui/icons-material/ReadMore';
import { saveQuestionnaireResponse } from '../../../api/saveQr.ts';
import useSmartClient from '../../../hooks/useSmartClient.ts';
Expand Down Expand Up @@ -75,10 +71,12 @@ function TokenTimerDialog(props: TokenTimerDialogProps) {
}

setIsSaving(true);
const responseToSave = removeEmptyAnswersFromResponse(
sourceQuestionnaire,
structuredClone(updatableResponse)
);
const responseToSave = structuredClone(updatableResponse);
// Temporarily comment out this line to avoid saving errors
// const responseToSave = removeEmptyAnswersFromResponse(
// sourceQuestionnaire,
// structuredClone(updatableResponse)
// );

responseToSave.status = 'in-progress';
saveQuestionnaireResponse(smartClient, patient, user, sourceQuestionnaire, responseToSave)
Expand Down
9 changes: 2 additions & 7 deletions apps/smart-forms-app/src/features/viewer/ResponsePreview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,7 @@ import parse from 'html-react-parser';
import { qrToHTML } from '../preview/utils/preview.ts';
import { Helmet } from 'react-helmet';
import PageHeading from '../dashboard/components/DashboardPages/PageHeading.tsx';
import {
removeEmptyAnswersFromResponse,
useQuestionnaireResponseStore,
useQuestionnaireStore
} from '@aehrc/smart-forms-renderer';
import { useQuestionnaireResponseStore, useQuestionnaireStore } from '@aehrc/smart-forms-renderer';

function ResponsePreview() {
const { setComponentRef } = useContext(PrintComponentRefContext);
Expand All @@ -49,8 +45,7 @@ function ResponsePreview() {
return <ViewerInvalid questionnaire={sourceQuestionnaire} />;
}

const responseCleaned = removeEmptyAnswersFromResponse(sourceQuestionnaire, sourceResponse);
const parsedHTML = parse(qrToHTML(sourceQuestionnaire, responseCleaned));
const parsedHTML = parse(qrToHTML(sourceQuestionnaire, sourceResponse));

return (
<>
Expand Down

0 comments on commit 0939fa4

Please sign in to comment.