Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fromFullPaths tail recursive #759

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

dianaamfr
Copy link
Contributor

@dianaamfr dianaamfr commented Nov 20, 2024

This proposes making fromFullPaths tail recursive to avoid StackOverflow exceptions if the size of the paths parameter is too long.

Does this change relate to existing issues or pull requests?

No.

Does this change require an update to the documentation?

No.

How has this been tested?

Existing and new unit tests.

@dianaamfr dianaamfr self-assigned this Nov 20, 2024
@dianaamfr dianaamfr requested a review from jcazevedo November 20, 2024 16:29
@dianaamfr dianaamfr marked this pull request as ready for review November 20, 2024 16:29
jcazevedo
jcazevedo previously approved these changes Nov 20, 2024
Copy link
Member

@jcazevedo jcazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good!

Copy link
Member

@jcazevedo jcazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jcazevedo jcazevedo merged commit 16599f9 into master Nov 21, 2024
14 checks passed
@jcazevedo jcazevedo deleted the make-fromFullPaths-tail-recursive branch November 21, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants