Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force empty line after top-level package statement #727

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

pmscosta
Copy link
Contributor

We try to always keep an empty line after the package statement at the top of the file, however we don't have this enforced by our scalafmt configuration files. This PR changes that in a hackish way given the following (as stated in here):

the rules do not directly apply to package statements at the top of the source file; however, if this parameter is non-empty, there will be at least one blank line before the first non-package statement, and possibly more if the rules match that statement

Does this change relate to existing issues or pull requests?

No.

Does this change require an update to the documentation?

No.

How has this been tested?

Tested locally by adding some empty lines in other places we want them and check that this does not remove them. Also ran a root scalafixAll.

@pmscosta pmscosta requested a review from jcazevedo September 10, 2024 08:05
Copy link
Member

@jcazevedo jcazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jcazevedo jcazevedo merged commit 851ffd6 into master Sep 10, 2024
14 checks passed
@jcazevedo jcazevedo deleted the scalamt-blank-after-package branch September 10, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants