Upgrade Unirest dependency to 4.2.0 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcazevedo
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Thanks!
One thing to note is that Unirest 4 requires at least Java 11 and we're currently publishing Apso (and running CI) in Java 8. This wasn't noticeable in CI because we don't use W in Apso's tests. We could keep publishing Apso using Java 8 and let downstream users deal with the incompatibilities (for those still in Java 8), but I think it might be safer to just embrace Java 11.
|
We can handle that in a separate PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Unirest dependency due to a concurrency issue that affected the version being used (Kong/unirest-java#92), and that was showing up when using
Win another project.Does this change relate to existing issues or pull requests?
No
Does this change require an update to the documentation?
No
How has this been tested?
Tested this manually.