Skip to content

OpenZeppelin Contracts initializer reentrancy may lead to double initialization

Moderate severity GitHub Reviewed Published Dec 14, 2021 in OpenZeppelin/openzeppelin-contracts • Updated Jan 28, 2023

Package

npm @openzeppelin/contracts (npm)

Affected versions

>= 3.2.0, < 4.4.1

Patched versions

4.4.1
npm @openzeppelin/contracts-upgradeable (npm)
>= 3.2.0, < 4.4.1
4.4.1

Description

Impact

Initializer functions that are invoked separate from contract creation (the most prominent example being minimal proxies) may be reentered if they make an untrusted non-view external call.

Once an initializer has finished running it can never be re-executed. However, an exception put in place to support multiple inheritance made reentrancy possible in the scenario described above, breaking the expectation that there is a single execution.

Note that upgradeable proxies are commonly initialized together with contract creation, where reentrancy is not feasible, so the impact of this issue is believed to be minor.

Patches

A fix is included in the version v4.4.1 of @openzeppelin/contracts and @openzeppelin/contracts-upgradeable.

Workarounds

Avoid untrusted external calls during initialization.

References

OpenZeppelin/openzeppelin-contracts#3006

Credits

This issue was identified and reported by @chaitinblockchain through our bug bounty on Immunefi.

For more information

If you have any questions or comments about this advisory, or need assistance executing the mitigation, email us at [email protected].

References

@frangio frangio published to OpenZeppelin/openzeppelin-contracts Dec 14, 2021
Reviewed Dec 14, 2021
Published to the GitHub Advisory Database Dec 14, 2021
Published by the National Vulnerability Database Nov 4, 2022
Last updated Jan 28, 2023

Severity

Moderate

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
High
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
Low
Integrity
Low
Availability
Low

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:L/I:L/A:L

EPSS score

0.141%
(50th percentile)

Weaknesses

CVE ID

CVE-2022-39384

GHSA ID

GHSA-9c22-pwxw-p6hx

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.