Ability to expose data in Sylius by using an unintended serialisation group
Moderate severity
GitHub Reviewed
Published
Jan 27, 2020
in
Sylius/SyliusResourceBundle
•
Updated Feb 7, 2024
Description
Reviewed
Jan 27, 2020
Published by the National Vulnerability Database
Jan 27, 2020
Published to the GitHub Advisory Database
Jan 31, 2020
Last updated
Feb 7, 2024
Impact
ResourceBundle accepts and uses any serialisation groups to be passed via a HTTP header. This might lead to data exposure by using an unintended serialisation group - for example it could make Shop API use a more permissive group from Admin API.
Anyone exposing an API with ResourceBundle's controller is affected. The vulnerable versions are:
<1.3 || >=1.3.0 <=1.3.12 || >=1.4.0 <=1.4.5 || >=1.5.0 <=1.5.0 || >=1.6.0 <=1.6.2
.Patches
The patch is provided for ResourceBundle 1.3.13, 1.4.6, 1.5.1 and 1.6.3, but not for any versions below 1.3.
After it is applied, It allows to choose only the groups that are defined in
serialization_groups
orallowed_serialization_groups
route definition. Any group not defined in those will not be used.This behaviour might be a BC break for those using custom groups via the HTTP header, please adjust
allowed_serialization_groups
accordingly.Workarounds
Service
sylius.resource_controller.request_configuration_factory
can be overridden with an implementation copied from\Sylius\Bundle\ResourceBundle\Controller\RequestConfigurationFactory
where the part that handles custom serialisation groups is deleted.References