Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

basic requirements #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

# dependencies
/node_modules
/package-lock.json
/.pnp
.pnp.js

Expand Down
6 changes: 6 additions & 0 deletions FOLLOW-UP-QUESTIONS.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,23 @@
# Follow-up questions

Please either commit your answeers to these questions inline, or submit the answers in an email to the hiring manager.

## 1. How did you find the task?

The minimum task was easy but was habing issues with creact react app so couldnt use sass and and typescript.

## 2. Did you feel you had enough time to complete the task in the way you wanted?

Yes, two hours were enough to complete the task.

## 3. If you had more time, what would you improve / add / do differently?

N/A I completed the task to the best of my ability.

## 4. Do you feel that your code is production ready / production quality? If not, what would you do to achieve this?

The main thing needed to make my code production ready is the inclusion of tests and may containerisation.

## 5. What additional libraries / frameworks / plugins did you use, and why?

I used tailwindCSS as provides seamless styling for react components. I saw this as the best option as I couldnt get SCSS to run properly.
Loading