Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finshing fixing the auth #28

Merged
merged 2 commits into from
Oct 13, 2023
Merged

finshing fixing the auth #28

merged 2 commits into from
Oct 13, 2023

Conversation

malekelkssas
Copy link
Collaborator

No description provided.

@@ -29,6 +29,15 @@ export const doctor = (app) => {
}
});

app.get('/check-doctor-req-user', async (req, res) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow REST conventions !!

@@ -17,6 +17,7 @@ export const admin = (app) => {

app.post('/add-admin', async (req, res) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REST conventions

@@ -16,10 +16,24 @@ class DoctorRepository {

async addDoctorReq(req){
const { userData, speciality, hourlyRate, affiliation, educationalBackground } = req.body;
const user = await DoctorModel.addUser(userData, speciality, hourlyRate, affiliation, educationalBackground);
const user = await DoctoerReqModel.addUser(userData, speciality, hourlyRate, affiliation, educationalBackground);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo

@amir-awad
Copy link
Collaborator

Please make sure that you tested all the endpoints using postman.

@YehiaFarghaly YehiaFarghaly merged commit 2ae550e into main Oct 13, 2023
0 of 3 checks passed
@malekelkssas malekelkssas deleted the fix_auth branch October 20, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants