Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original PCAP timestamps instead of timeofday-generated #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

infokek
Copy link

@infokek infokek commented Aug 20, 2024

I suggest to change PCAP logger code cause of bad timestamps. Timeofday-generated timestamps are not so good for zeek or any dpi parsing (the packages are not in the right order). Also original timestamps seems to be better in PCAP cause it helps to see the real time of the package (for example in Wireshark).

For example on one malware traffic (Smert Ransomware):
PCAP source: https://app.any.run/tasks/5b2f8a32-62ea-47b1-9c3a-b9b474fb0774/
Original pcap timestamps (Wireshark with SSLKeyLogFile specified in settings):

image

Current ssldump version (gettimeofday-generated timestamps - decrypted at 7 Aug):
image

This PR's version:
image

This feature may be very helpful for some malware traffic analysts in future and seems to be more correctly. Please correct me if I'm wrong somewhere.

@adulau adulau self-requested a review August 21, 2024 13:25
@infokek
Copy link
Author

infokek commented Sep 11, 2024

Hi, @adulau. Maybe I need to make some fixes to the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant