Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a figure if error in umat.plot() #934

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

adtzlr
Copy link
Owner

@adtzlr adtzlr commented Feb 8, 2025

See also #931 - this avoids unnecessary figures created in the tests. If non-physical stretches are present, no (empty) figure is created.

@adtzlr adtzlr added the enhancement New feature or request label Feb 8, 2025
@adtzlr adtzlr self-assigned this Feb 8, 2025
@adtzlr adtzlr mentioned this pull request Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (7f40c66) to head (e855101).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #934   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files         181      181           
  Lines        6510     6510           
=======================================
  Hits         6327     6327           
  Misses        183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adtzlr adtzlr merged commit 0fcab9c into main Feb 8, 2025
5 checks passed
@adtzlr adtzlr deleted the enhance-umat-plot branch February 8, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant