modern ircdocs tweak #120
Open
modern ircdocs tweak #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm in the process of requesting that modern-ircdocs be revised to avoid this situation, but in the event that this doesn't go through, here's the bare minimum of what fussy clients will expect
adsr
reviewed
Feb 6, 2023
| // Send RPL_ISUPPORT | ||
| this.ircd.write(ircUser.socket, 'irslackd', '005', [ | ||
| ircUser.ircNick, | ||
| 'CHANTYPES=#', |
There was a problem hiding this comment.
There's also a debug channel that uses the & prefix. Would that also belong here?
emersion
reviewed
Feb 8, 2023
| this.ircd.write(ircUser.socket, 'irslackd', '005', [ | ||
| ircUser.ircNick, | ||
| 'CHANTYPES=#', | ||
| ':are supported by this server' |
There was a problem hiding this comment.
Nit: no need to manually stick the :, the library will do it for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of requesting that modern-ircdocs be revised to avoid this situation, but in the event that this doesn't go through, here's the bare minimum of what fussy clients will expect.