Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: upgrade upload/download-artifact GitHub actions #353

Closed

Conversation

neutrinoceros
Copy link
Contributor

Describe your changes

Hi, version 4 of upload-artifact and download-artifact were recently released.
Staying on old version is not viable long term because GitHub will sooner or later drop support for the old versions of node that these depend on.
Since migration to v4 is not as straightfoward as bumping the version number, I'm helping all astropy-related packages byt manually performing the necessary changes.

Checklist

  • Did you add tests?
  • Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@neutrinoceros neutrinoceros marked this pull request as draft January 5, 2024 11:18
@neutrinoceros neutrinoceros force-pushed the mnt/upload-artifacts-v4 branch from 9064e8b to 910b4ee Compare January 5, 2024 11:21
@neutrinoceros neutrinoceros marked this pull request as ready for review January 5, 2024 13:26
@adrn
Copy link
Owner

adrn commented Feb 13, 2024

Thanks for this! It took a little more fiddling, but this set me on the right path.

@adrn adrn closed this Feb 13, 2024
@adrn
Copy link
Owner

adrn commented Feb 13, 2024

(see #361)

@neutrinoceros neutrinoceros deleted the mnt/upload-artifacts-v4 branch February 13, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants