Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO for SCF potentials #338

Merged
merged 5 commits into from
Sep 21, 2023
Merged

IO for SCF potentials #338

merged 5 commits into from
Sep 21, 2023

Conversation

TomWagg
Copy link
Contributor

@TomWagg TomWagg commented Sep 21, 2023

Describe your changes

I tweaked the potential __init__.py so that it can find SCF potentials, which ensures that IO will work for them. I also added a test for this (hopefully in the right place/correctly) which passes for me now.

Checklist

  • Did you add tests?
  • Did you add documentation for your changes?
  • Did you reference any relevant issues?
  • Did you add a changelog entry? (see CHANGES.rst)
  • Are the CI tests passing?
  • Is the milestone set?

@TomWagg TomWagg changed the title Scf io IO for SCF potentials Sep 21, 2023
@TomWagg
Copy link
Contributor Author

TomWagg commented Sep 21, 2023

@adrn unsure what to do with the failing test - it fails because GSL isn't installed (makes sense) but not sure how to tell it to skip that test - would it make sense to just check gala._cconfig.GSL_ENABLED and only do the rest of the test if it is? Or is there something smarter?

@adrn
Copy link
Owner

adrn commented Sep 21, 2023

In the test file, you can do from gala._cconfig import GSL_ENABLED and then skip the test if that is false. Examples here: https://github.com/adrn/gala/blob/main/gala/potential/potential/tests/test_all_builtin.py#L222

@adrn adrn added this to the v1.8 milestone Sep 21, 2023
@TomWagg
Copy link
Contributor Author

TomWagg commented Sep 21, 2023

Cool! I knew you'd have a fancy method 🙃

It should be all set now!

@adrn adrn merged commit 44c361b into adrn:main Sep 21, 2023
15 checks passed
@adrn
Copy link
Owner

adrn commented Sep 21, 2023

Thanks @TomWagg !!

@TomWagg TomWagg deleted the scf-io branch September 21, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants