Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subscriptions): add option 'proration_behavior.always_invoice' for updates #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arnaldop
Copy link

@arnaldop arnaldop commented Oct 9, 2022

Also adds requirements.txt to make building easier and updates README.

@H--o-l
Copy link
Collaborator

H--o-l commented Oct 10, 2022

Hey @arnaldop, thanks for contributing!

About the requirements.txt I'm not a fan because setup.py describe them well already. Do a pip3 install --user -e . and you'd be done with it.
Also, it's common practice so I'm not sure it should ends-up in the README.

Could you reduce the title length for the second commit so it fits in a GitHub line (see the ... in the screen below)?
2022-10-10-102928_grim

Last thing, could you add an explanation in the commit message about what this change is, what it does, links to the real Stripe API to show us where it comes from, etc.
We don't know Stripe API by heart, and we will have to maintain the change you propose in the long term, so can you advocate your change to us?

The last thing, did adding a test would make sense? If not can you explain why? If yes could you add a test?

Thanks in advance!

@arnaldop arnaldop changed the title feat(subscriptions): add 'always_invoice' to 'proration_behavior' options for subscription updates feat(subscriptions): add option 'proration_behavior.always_invoice' for updates Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants