This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Add the "interface" method to get public IP #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for your contribution. So if I understand, it'll work for devices which are not behind a NAT? |
|
Yes. I have a globally routable IPv4 address on my router. But my ISP is really bad. There is NAT on the way to some websites, including icanhazip.com. I can't get correct IP with them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ISPs do NAT on the way to public IP discovery services like icanhazip.com.
This MR adds a new method to get public IP, which is to get it from IP of primary interface directly.