Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ForwardDiff extension #203

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Remove ForwardDiff extension #203

merged 1 commit into from
Oct 2, 2024

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented Oct 2, 2024

This package reverts #200 for the reasons described here:

With #200, ForwardDiff.Dual are treated just like any other Real number, meaning that multiplication with a global tracer basically ignores the ForwardDiff.Dual. However, ForwardDiff.Dual could in theory contain SCT's tracers (either in the primal value, in the partials, or in both), thus returning wrong, non-conservative sparsity patterns.

While this is a general issue with Real number wrapper types, I feel like adding a ForwardDiff extension would signal full support for ForwardDiff.Dual. I therefore suggest reverting the changes in #200.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (bb7d365) to head (10154d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   90.91%   90.74%   -0.17%     
==========================================
  Files          49       47       -2     
  Lines        2113     2107       -6     
==========================================
- Hits         1921     1912       -9     
- Misses        192      195       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill merged commit 3072d4a into main Oct 2, 2024
9 checks passed
@adrhill adrhill deleted the ah/remove-fwdiff-ext branch October 2, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants