Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LogExpFunctions compat entry #195

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix LogExpFunctions compat entry #195

merged 1 commit into from
Sep 23, 2024

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented Sep 23, 2024

loglogistic, logitexp, log1mlogistic and logit1mexp are only available in LogExpFunctions.jl v0.3.28. Unfortunately, the compat entry previously wasn't restrictive enough.

CC @aziehe.

@adrhill adrhill added the bug Something isn't working label Sep 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (36fc3a4) to head (d823eb2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files          48       48           
  Lines        2087     2087           
=======================================
  Hits         1918     1918           
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill merged commit f0f8c92 into main Sep 23, 2024
6 checks passed
@adrhill adrhill deleted the ah/fix-logexp-compat branch September 23, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants