Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to TracerSparsityDetector as detector instead of method #191

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented Sep 5, 2024

This was previously inconsistent. detector is less ambiguous than method and matches ADTypes.jl's *Detector naming convention.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.90%. Comparing base (87f026a) to head (10822de).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
test/test_gradient.jl 66.66% 1 Missing ⚠️
test/test_hessian.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files          48       48           
  Lines        2087     2087           
=======================================
  Hits         1918     1918           
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill adrhill merged commit 4637817 into main Sep 5, 2024
6 checks passed
@adrhill adrhill deleted the ah/docs-detector branch September 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants